Skip to content

Added Static typing using type annotations and mypy #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 2, 2018
Merged

Conversation

syrusakbary
Copy link
Member

@syrusakbary syrusakbary commented Jun 23, 2018

Added Static typing to graphql-core.
It should help to anyone using the library so they can have autocompletion and static type analyisis on their code.

  • Use pyannotate to automatically annotate all types
  • Fixed automatic imports from pyannotate
  • Fixed flake8
  • Use black to autoformat all the files
  • Correct annotations, making mypy pass (and eventually pyre-check)
  • Add mypy checks to Travis
  • Check one by one all files and declarations to make sure they are properly annotated

@syrusakbary syrusakbary mentioned this pull request Jun 23, 2018
@syrusakbary syrusakbary changed the title [WIP] Added Static typing to graphql-core Added Static typing using type annotations and mypy Jul 2, 2018
@syrusakbary syrusakbary merged commit fa4eeda into master Jul 2, 2018
@ProjectCheshire ProjectCheshire deleted the statictypes branch June 2, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant